RFA: PATCH to finalize_record_size to avoid ABI changes from -Wpacked (c++/41788)

Richard Guenther richard.guenther@gmail.com
Fri Apr 9 15:10:00 GMT 2010


On Fri, Apr 9, 2010 at 4:59 PM, Jason Merrill <jason@redhat.com> wrote:
> Bug 41788 pointed out that -Wpacked changed the layout of a class by
> unsetting TYPE_PACKED when it seemed unnecessary.  For 4.5 I fixed that bug
> by making it clear that the flag is actually necessary for that testcase,
> but in general it seems wrong for the compiler to change layout based on a
> warning flag.  So this patch changes finalize_record_size to only give the
> warning, not actually unset the flag.
>
> Tested x86_64-unknown-linux-gnu.  OK for trunk?
>

Ok.

Thanks,
RIchard.



More information about the Gcc-patches mailing list