[Patch V3] Fix bootstrap/43684 (was) Re: [Patch] Remove "set but unused" vars from rs6000.c.
Jakub Jelinek
jakub@redhat.com
Fri Apr 9 13:28:00 GMT 2010
On Fri, Apr 09, 2010 at 08:26:49AM -0400, Diego Novillo wrote:
> > case OPTION_static:
> > +#ifdef HAVE_LD_STATIC_DYNAMIC
> > static_linking = 1;
> > +#endif
> >
> > case OPTION_l:
>
> Is the fall through intentional? If so, could you add the comment
> /* FALLTHRU */?
I believe there should be break; instead of FALLTHRU -
this is about whether
gfortran -o foo -static
should complain or not. It actually complains even without the
break, but for very different reason - lookup_option never returns
OPTION_static, guess PR31400 change was buggy.
So, static_linking is never actually set to non-zero.
Jakub
More information about the Gcc-patches
mailing list