[4.6 PATCH] -Wunused-but-set-{variable,parameter} (PR c/18624)

Tom Tromey tromey@redhat.com
Wed Apr 7 18:00:00 GMT 2010


>>>>> "Jakub" == Jakub Jelinek <jakub@redhat.com> writes:

Jakub> Here are updated patches for C -Wunused-but-set-* support,
Jakub> bootstrapped/regtested on x86_64-linux and
Jakub> i686-linux.  The C parts of the first patch have been approved
Jakub> by Joseph already earlier, so I'm just seeking approval for the
Jakub> rest of the changes.

Jakub> Ok for trunk?

The java front end changes seem a little ugly, but I don't see any
better way to handle them, given that a lot of the code is in macros
that are used in different contexts.

The only change I don't get is the classpath one.  Can we just remove
'rc'?  Upstream Classpath doesn't rely on GCC, so we'd need to
conditionalize the attribute... but if we removed rc entirely then we
could put the patch upstream as-is.

The rest (java, libjava, libffi) are ok, thanks.

Tom



More information about the Gcc-patches mailing list