[PATCH][C++] Kill expr_size langhook

Jason Merrill jason@redhat.com
Fri Sep 4 16:04:00 GMT 2009


On 09/03/2009 01:19 PM, Richard Guenther wrote:
> On Thu, 3 Sep 2009, Jason Merrill wrote:
>
>> On 08/29/2009 09:47 AM, Richard Guenther wrote:
>>>
>>> This kills the expr_size langhook.  With the recent C++ FE change
>>> there isn't any language-specific semantics left that warrant it.
>>
>> Perhaps not semantics, but having the langhook return NULL for
>> non-byte-copyable classes has caught a number of bugs which otherwise would
>> have been hard to detect wrong codegen.
>
> Those are types with TREE_ADDRESSABLE set, no?  So I guess a strategical
> check somewhere in verify_gimple_* might be as good.

Types with TREE_ADDRESSABLE can still be bitwise assigned if they have a 
trivial copy assignment operator, the backend just can't create extra 
copies.

Jason



More information about the Gcc-patches mailing list