[vta->trunk] VTA merge

Richard Guenther richard.guenther@gmail.com
Tue Sep 1 08:54:00 GMT 2009


On Tue, Sep 1, 2009 at 6:42 AM, Alexandre Oliva<aoliva@redhat.com> wrote:
> On Aug 31, 2009, Richard Henderson <rth@redhat.com> wrote:
>
>>> +      if (!id->debug_stmts)
>>> +        id->debug_stmts = VEC_alloc (gimple, heap, 1);
>>> +      VEC_safe_push (gimple, heap, id->debug_stmts, copy);
>
>> Note that VEC_safe_push will also handle the initial
>> allocation of the VEC from NULL.  It's quite handy.
>
> Aah, indeed, this makes room for a few simplifications.  Even more so
> because id is zero initialized.
>
> Here's the revised patch I'm testing now, with a few additional
> adjustments.  It has already completed bootstrap on i686-pc-linux-gnu.

Looks good to me.  Well, let's just go forward with it - we obviously disagree
about the added abstraction at this point.  I'm looking forward to you
adding other kinds of debug instructions in the near future.  Or at least
a hint on what they could be.

Thanks,
Richard.

>
>
> --
> Alexandre Oliva, freedom fighter    http://FSFLA.org/~lxoliva/
> You must be the change you wish to see in the world. -- Gandhi
> Be Free! -- http://FSFLA.org/   FSF Latin America board member
> Free Software Evangelist      Red Hat Brazil Compiler Engineer
>
>



More information about the Gcc-patches mailing list