[PATCH: PR target/41705] Enable if conversion for thumb1 by new HAVE_conditional_execution definition

Ian Lance Taylor iant@google.com
Sat Oct 17 01:40:00 GMT 2009


Carrot Wei <carrot@google.com> writes:

> Index: ifcvt.c
> ===================================================================
> --- ifcvt.c     (revision 152888)
> +++ ifcvt.c     (working copy)
> @@ -21,13 +21,13 @@
>  #include "config.h"
>  #include "system.h"
>  #include "coretypes.h"
> +#include "insn-config.h"
>  #include "tm.h"
>
>  #include "rtl.h"
>  #include "regs.h"
>  #include "function.h"
>  #include "flags.h"
> -#include "insn-config.h"
>  #include "recog.h"
>  #include "except.h"
>  #include "hard-reg-set.h"


No.  The order of the main #includes is fairly canonical across gcc
source files.  Requiring one file to do things differently is certain
to break over time.

One thing you could do is have genconfig.c look for the predicate of
define_cond_exec, and use it as the value of
HAVE_conditional_execution.  I don't know how well that would work.

The quick solution would be to introduce a new target hook and change
every place that checks HAVE_conditional_execution to check that.

Ian



More information about the Gcc-patches mailing list