[RFA:] Fix PR 40086 - reorg.c again and again
Jeff Law
law@redhat.com
Mon Nov 30 21:53:00 GMT 2009
On 11/29/09 18:31, Hans-Peter Nilsson wrote:
>> From: Eric Botcazou<ebotcazou@adacore.com>
>> Date: Tue, 19 May 2009 09:11:44 +0200
>>
> Sorry for the delay.
>
>
>>> No, as safe correctness was the issue I prioritized re-using the
>>> previous solution. I thought it couldn't happen too often, or
>>> this bug would have been noticed before. What indications of
>>> non-pessimization do you require?
>>>
>> For example looking at the impact on gcc.c-torture/compile at -O2 to get a
>> quick idea. I've attached a patch (originally from Richard S. IIRC) that
>> preserves the assembly files generated for this directory.
>>
> I finally did this, and of the 991 assembly files, there were
> (as I expected) no differences for revision 154742 for cris-elf
> before/after the patch.
>
> Ok to commit now?
> <http://gcc.gnu.org/ml/gcc-patches/2009-05/msg00811.html>
>
A blast from the past. I hate when we end up effectively doing the same
analysis & bugfix over and over. I'm OK with this patch for the
mainline sources. I'd also approve a patch which changed the remaining
next_active_insn with next_real_insn within reorg.c and resource.c after
mainline branches.
jeff
More information about the Gcc-patches
mailing list