[C++/cgraph] Middle-end thunk support

Jan Hubicka hubicka@ucw.cz
Fri Nov 27 16:25:00 GMT 2009


> > +           fprintf (f, " %s", cgraph_node_name (n));
> 
> Can you please dump also the UID like you do everywhere else?  With
> long C++ names, uids are the only hope to quickly identify the nodes I
> am after.

Will do even if thunks come out in mangled form for whatever reason, so they are
easier to handle then your average C++ function name.
> > +           ptrtmp = create_tmp_var (TREE_TYPE (ptr), "ptr");
> > +           stmt = gimple_build_assign (ptrtmp, ptr);
> > + 	  gsi_insert_after (bsi, stmt, GSI_NEW_STMT);
> > + 	  mark_symbols_for_renaming (stmt);
> > + 	  find_referenced_vars_in (stmt);
> > + 	}
> 
> I think that force_gimple_operand_gsi is what you want to use instead
> of the whole if statement above.

Yes, it would be more compact equivalent, will give it a try ;)
> 
> These changes look rather unrelated and are not in the Changelog so I
> guess it is also unintentional?

Yes, they was just change to IRA to avoid enumerating loop boides over and over
I sent to other thread.

Honza
> 
> Thanks,
> 
> Martin



More information about the Gcc-patches mailing list