[PATCH] Disable vrp47 for S/390

H.J. Lu hjl.tools@gmail.com
Sat Nov 21 20:44:00 GMT 2009


On Fri, Nov 20, 2009 at 11:40 PM, Andreas Krebbel
<krebbel@linux.vnet.ibm.com> wrote:
> Hi,
>
>>>  /* Skip on MIPS, where LOGICAL_OP_NON_SHORT_CIRCUIT inhibits the setcc
>>>    optimizations that expose the VRP opportunity.  */
>>> ! /* Skip on S/390.  Lower values in BRANCH_COST lead to two conditional
>>> !    jumps when evaluating an && condition.  VRP is not able to optimize
>>> !    this.  */
>>> ! /* { dg-do compile { target { ! mips*-*-* ! s390*-*-* } } } */
>>
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>
>> This isn't correct syntax.
>
> Mmh it worked for me and I hope for mips as well.  What is the preferred
> syntax? There does not seem to be THE way to do it. Searching the testsuite
> I find various ways:
>
> /* { dg-do compile { target { ! { mips*-*-* s390*-*-* } } } } */
> /* { dg-do compile { target { { ! mips*-*-* } && { ! s390*-*-* } } } } */
>
> I have picked the last version since this seems to be the most frequently
> used one.

You used

/* { dg-do compile { target { ! mips*-*-* ! s390*-*-* } } } */

It is different from

 /* { dg-do compile { target { { ! mips*-*-* } && { ! s390*-*-* } } } } */

You missed && and {}.

-- 
H.J.



More information about the Gcc-patches mailing list