[vta, graphite?] propagate degenerate phi nodes into debug stmts

Alexandre Oliva aoliva@redhat.com
Fri Nov 20 09:26:00 GMT 2009


On Nov 19, 2009, Richard Guenther <richard.guenther@gmail.com> wrote:

> On Thu, Nov 19, 2009 at 5:27 AM, Alexandre Oliva <aoliva@redhat.com> wrote:
>> On Nov 17, 2009, Richard Guenther <richard.guenther@gmail.com> wrote:
>> 
>>> Well, just adjust degenerate_phi_result to do instead of calling
>>> operand_equal_p
>> 
>>>   else if (TREE_CODE (arg) != TREE_CODE (val)
>>>              || (TREE_CODE (arg) == SSA_NAME
>>>                  && arg != val)
>>>              || !operand_equal_p (arg, val, 0))
>>>     break;
>> 
>>> that should fix it.
>> 
>> Good idea.

>> Here's what I'm testing now.

> Ok if it passes testing.

Thanks, but arg could be NULL, and then TREE_CODE (val) would crash.

The fixed patch below corrects the two regressions I got testing the
patch on x86_64-linux-gnu.  Save for new regressions, I'll check in the
revised version as soon as my current round of testing completes.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: vta-ssa-dom-prop-degenerate.patch
Type: text/x-diff
Size: 2681 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20091120/dba151b8/attachment.bin>
-------------- next part --------------

-- 
Alexandre Oliva, freedom fighter    http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/   FSF Latin America board member
Free Software Evangelist      Red Hat Brazil Compiler Engineer


More information about the Gcc-patches mailing list