fix -fcompare-debug regression in asm locators

Alexandre Oliva aoliva@redhat.com
Sun Nov 8 07:28:00 GMT 2009


On Oct 17, 2009, Alexandre Oliva <aoliva@redhat.com> wrote:

> 1. pass it to build_asm_expr() instead of the locus of the ASM keyword,
> and use that location for the stmt.  It will get to the gimple tuple,
> and end up in the RTX insn.  It would render the loci in ASM_OPERANDS
> and ASM_INPUT obsolete.

> 2. pass it to build_asm_expr() in addition to the locus of the ASM
> keyword, and add the location_t to the ASM_EXPR tree.  Use it when
> expanding GIMPLE_ASMs to RTX, so as to fill in the locus field in
> ASM_OPERANDS and ASM_INPUT.

> Which way should we go?


> In the mean time (I'm going to be away for most of next week), here's a
> patch that uses the locus of the stmt, rather than input_location, to
> fill in the locus field in ASM_OPERANDS and ASM_INPUT.  Is this ok to
> install?

Ping?

> for  gcc/ChangeLog
> from  Alexandre Oliva  <aoliva@redhat.com>

> 	* stmt.c (expand_asm_stmt): Get locus from stmt.

http://gcc.gnu.org/ml/gcc-patches/2009-10/msg01112.html

-- 
Alexandre Oliva, freedom fighter    http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/   FSF Latin America board member
Free Software Evangelist      Red Hat Brazil Compiler Engineer



More information about the Gcc-patches mailing list