[patch, configures] Unify AC_SYS_LARGEFILE exception across dirs
Paolo Bonzini
bonzini@gnu.org
Fri Nov 6 00:00:00 GMT 2009
On 11/05/2009 11:11 PM, Jan Kratochvil wrote:
> On Thu, 05 Nov 2009 21:52:14 +0100, Paolo Bonzini wrote:
>> On 11/05/2009 12:20 AM, Jan Kratochvil wrote:
>>> +case "${target}" in
>>
>> This is a host test. You need
>>
>> +case "${host}" in
Even if the target = host test shall remain, I would say that the case
statement is clearer if you use the host.
>>> + if test "${target}" = "${host}" [...]
>
> This was already being discussed in:
> http://www.sourceware.org/ml/binutils/2008-11/msg00095.html
>
> as this exception is required only for this case:
I'm not sure I understand the rationale, but that's fine if it was
discussed on the mailing lists.
> "$enable_largefile" != 'yes' should also remain there if we want to
> keep the current IMHO-right behavior existing there and tested for a
> year in bfd/ of binutils and gdb releases:
This was not changed because I used
: ${enable_largefile=no}
The reason for this change is that the Autoconf test uses
"$enable_largefile" != 'no', so changing anything the user gives
(including --enable-largefile= i.e. the empty string) to 'no' is
undesirable.
Paolo
More information about the Gcc-patches
mailing list