revised patch committed.
Jeff Law
law@redhat.com
Thu Nov 5 18:22:00 GMT 2009
On 11/05/09 09:50, Kenneth Zadeck wrote:
>
> The main reason that this was missed was that there are no public,
> active ports that actually do this. I accepted the patch on Ian
> Taylor's (iant) advice because he said that it was legal as long as the
> mem was a single byte. Iant claimed that the last machine that could
> do this kind of thing was the 68k but in his comments he did not
> actually say if the gcc port actually did it. Thus, you are really on
> your own as to finding out how much else is broken to support this feature.
>
I believe the H8 port generates
(set (zero_extract (mem)))
in certain circumstances. Unfortunately, limitations of GCC's
insv/extv support make it much more difficult than it should be to
generate these kinds of insn on the H8 series processors.
> I think that the policy is that we accept patches from private ports as
> long as they are fix problems with things that are supposed to work.
> Certainly no one has pushed back on me for accepting your first patch.
Right. Obviously with a private port it usually takes a more thorough
description of the problem as the review isn't able to fire up a
debugger if they needed to understand how a particular hunk code was
behaving.
jeff
More information about the Gcc-patches
mailing list