[patch mingw]: Adds for mingw targets the EH thread code to libgcc

Danny Smith dansmister@gmail.com
Sun May 31 07:38:00 GMT 2009


On Sat, May 30, 2009 at 9:40 PM, Kai Tietz <ktietz70@googlemail.com> wrote:
> 2009/5/28 Dave Korn <dave.korn.cygwin@googlemail.com>:
>> Kai Tietz wrote:
>>
>>> I tested this patch for i686-pc-cygwin and for i686-pc-mingw32 (by
>>> mingw.org's runtime).
>>
>>> Is this patch ok for apply, or are there any further suggestions, or any
>>> objectives?
>>
>>  No objections.  I think that:
>>
>>>         * gthr-win32.h (MINGW32_SUPPORTS_MT_EH): Define
>>>         it for targets defining _WIN32 but not __CYGWIN__.
>>
>> ... you don't really need to worry too much about this angle.  We don't
>> support win32 threads on Cygwin, only --enable-threads=posix is important to us.
>>
>>    cheers,
>>      DaveK
>>
>
> Ok, I applied it. As we have now mthreads support in shared libgcc, we
> should deprecate the -mthreads option, or we should change spec files
> here and avoid the linking of libmingwthrd.a at all. If we do so, we
> need to add the definition of _CRT_MT for static libgcc, too.
> Danny, what's your opinion about this?

That would break  multiple thread support for the case of static
libgcc, which is still the default configuartion for mingw32.
There were discussions about this on the mingw32 list awhile ago, and
the consensus was that breaking static libgcc usage was  not nice.\\
Danny


> Cheers,
> Kai
>
>
> --
> |  (\_/) This is Bunny. Copy and paste
> | (='.'=) Bunny into your signature to help
> | (")_(") him gain world domination
>



More information about the Gcc-patches mailing list