[PR40159,trunk,vta,vta4.4] don't succeed on failures in recursive make

[Alexandre Oliva]

On May 19, 2009, Dave Korn <dave.korn.cygwin@googlemail.com> wrote:

> Alexandre Oliva wrote:
>> On May 18, 2009, Alexandre Oliva <aoliva@redhat.com> wrote:
>> 
>>> Andreas Schwab reminds me I'm no longer suited to be a configury
>>> maintainer :-)
>> 
>> And H-P reinforces the point ;-) reminding me gcc-bootstrap and
>> gcc-no-bootstrap aren't mutually exclusive.  :-/

>   I hate to make you feel like it's beat-up-on-Alex day :-)

:-)

> -	if [ -f stage_last ]; then : ; \
> +	if [ -f stage_last ]; then \
>  	  TFLAGS="$(STAGE$(shell sed s,^stage,, stage_last)_TFLAGS)"; \

> ... $(shell) is evaluated by make, regardless of the [ -f ] test.  This leads
> to a harmless (I think?) warning at the start of a clean build:

Rats.  I was pretty sure this would never hit, because stage_last would
be created by unstage before we got to that point.  But if it would
never hit, why would we have the if test anyway, right?  Doh!

Fixed as follows.  Thanks.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: bootstrap-configs-oops-pr40159-more2.patch
Type: text/x-patch
Size: 1338 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20090527/52b50058/attachment.bin>
-------------- next part --------------


-- 
Alexandre Oliva, freedom fighter    http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/   FSF Latin America board member
Free Software Evangelist      Red Hat Brazil Compiler Engineer