[patch] Don't require -DIN_GCC while compiling plugins

[Rafael Espindola]

> It's better to have gcc-plugin.h include config.h and system.h or
> document that the three files should be included in the order:
> config.h, system.h ggc-plugin.h.

Why? That is a much more complicated user interface for just one use
of "bool". It is nice to have gcc-plugin.h very light.

If you want a "everything a plugin will ever need" header, we should
probably create a new file that just includes lots of other files
(gcc-plugin.h being among them).

>
>> 2009-05-26  Rafael Avila de Espindola  <espindola@google.com>
>>
>>        * gcc-plugin.h (IN_GCC) Define if not defined.
>>        (plugin_default_version_check): Return int.
>>        * plugin.c (plugin_default_version_check): Return int.
>>
>> 2009-05-26  Rafael Avila de Espindola  <espindola@google.com>
>>
>>        * g++.dg/plugin/attribute_plugin.c: Include gcc-plugin.h first.
>>        * g++.dg/plugin/dumb_plugin.c: Include gcc-plugin.h first.
>>        * g++.dg/plugin/selfassign.c: Include gcc-plugin.h first.
>>        * gcc.dg/plugin/selfassign.c: Include gcc-plugin.h first.
>
> Could you also add documentation in plugin.texi describing this requirement?

I documented gcc-header being the first gcc header.

OK?

>
> Thanks.  Diego.
>

Cheers,
-- 
Rafael Avila de Espindola

Google | Gordon House | Barrow Street | Dublin 4 | Ireland
Registered in Dublin, Ireland | Registration Number: 368047
-------------- next part --------------
A non-text attachment was scrubbed...
Name: in-gcc.patch
Type: text/x-diff
Size: 4702 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20090526/d7650426/attachment.bin>