adding GGC events for plugins.
Diego Novillo
dnovillo@google.com
Tue May 26 15:33:00 GMT 2009
On Mon, May 25, 2009 at 10:32, Basile STARYNKEVITCH
<basile@starynkevitch.net> wrote:
> + This is also called without a callback routine for the
> + PLUGIN_PASS_MANAGER_SETUP, PLUGIN_INFO, PLUGIN_REGISTER_GGC_ROOTS
> + pseudo-events, with a specific user_data.
> + */
Close comment in previous line as '. */'.
> +
> +/* Dynamically register a new GGC root table. This is useful for
> + plugins */
> +void
Blank line after comment.
End comment with '. */'
RT needs to be documented.
> @@ -106,6 +135,19 @@
> for (i = 0; i < rti->nelt; i++)
> (*rti->cb)(*(void **)((char *)rti->base + rti->stride * i));
>
> + if (extra_root_vec && VEC_length(const_ggc_root_tab_t,extra_root_vec)>0)
Blank space around '>'. Align predicates vertically to avoid
line wrapping.
> + for (rti = rtp; rti->base != NULL; rti++)
> + for (i = 0; i < rti->nelt; i++)
> + (*rti->cb)(*(void **)((char *)rti->base + rti->stride * i));
Space after '->cb)' and 'void **)'.
> +
> + /* Some plugins may call ggc_set_mark from here. */
End comment with '. */'
OK with those changes.
Diego.
More information about the Gcc-patches
mailing list