[fortran,patch] Impose limit on string length

FX fxcoudert@gmail.com
Sat May 16 16:42:00 GMT 2009


> 1) Your testcase appear to be missing '! { dg-do compile }' or
>   '! { dg-do run }' directives.

Indeed. They should be "dg-do compile".

> 2) Do the testcases require a system with a large amount of memory?

No, none of them compile.


> +	  gfc_error ("Substring end index at %L is too large",
> +		     &ref->u.ss.start->where);
>
> Shouldn't this be ref->u.ss.end->where?

Indeed.

> +  /* Check that the character length is not to large.  */
>
> s/to/too

Been there, done that (so many times).

With these answers, is it OK?

Thanks for the review,
FX



More information about the Gcc-patches mailing list