RFA: [PR objc/27377] Fix warnings about conditional expressions for compatible ObjC types

David Ayers ayers@fsfe.org
Sun Mar 29 09:34:00 GMT 2009


Am Freitag, den 27.03.2009, 22:50 -0700 schrieb Ian Lance Taylor:
> David Ayers <ayers@fsfe.org> writes:
> 
> > gcc/
> > 2009-03-00  David Ayers  <ayers@fsfe.org>
> >
> > 	PR objc/27377
> > 	* gcc/c-typeck.c (build_conditional_expr): Emit ObjC warnings
> > 	by calling objc_compare_types and surpress warnings about
> > 	incompatible C pointers that are compatible ObjC pointers.
> > 	
> > testsuite/
> > 2009-03-00  David Ayers  <ayers@fsfe.org>
> >
> > 	PR objc/27377
> > 	* gcc/testsuite/objc.dg/conditional-1.m: New tests.
> 
> 
> > Index: gcc/c-typeck.c
> > ===================================================================
> > --- gcc/c-typeck.c	(Revision 144857)
> > +++ gcc/c-typeck.c	(Arbeitskopie)
> > @@ -3438,6 +3438,9 @@
> >    tree result_type = NULL;
> >    tree orig_op1 = op1, orig_op2 = op2;
> >  
> > +  /* True means types are compatible as far as ObjC is concerned.  */
> > +  bool objc_ok;
> > +
> 
> Comments are normally good but this comment is unnecessary: the name of
> the variable says it all.  Just declare the variable, with no comment
> and no preceding blank line.
> 
> 
> This is OK for mainline with that change.

Committed with that change.

Thanks!
David



More information about the Gcc-patches mailing list