[graphite] Fix PR39447: ICE in create_data_ref

H.J. Lu hjl.tools@gmail.com
Wed Mar 18 21:57:00 GMT 2009


On Tue, Mar 17, 2009 at 12:56 PM, Janis Johnson <janis187@us.ibm.com> wrote:
> On Tue, 2009-03-17 at 01:01 -0500, Sebastian Pop wrote:
>> Hi,
>>
>> Attached is a patch that fixes PR39447 by looking at whether the
>> operand contains COMPONENT_REFs before calling the data reference
>> analysis, not after.
>>
>> The patch contains a new directory in the testsuite for C++ testcases
>> and a new graphite.exp file that I adapted from gcc.dg.  Janis, could
>> you please have a look at the graphite.exp file?
>>
>> The patch regstrapped on amd64-linux.  Okay for trunk?
>
> The testsuite change is OK.
>

The testcase patch caused:

Executing on host:
/export/build/gnu/gcc/build-i686-linux/gcc/testsuite/g++2/../../g++
-B/export/build/gnu/gcc/build-i686-linux/gcc/testsuite/g++2/../../
/net/gnu-13/export/gnu/src/gcc/gcc/gcc/testsuite/g++.dg/graphite/pr39447.C
 -nostdinc++ -I/export/build/gnu/gcc/build-i686-linux/i686-pc-linux-gnu/libstdc++-v3/include/i686-pc-linux-gnu
-I/export/build/gnu/gcc/build-i686-linux/i686-pc-linux-gnu/libstdc++-v3/include
-I/net/gnu-13/export/gnu/src/gcc/gcc/libstdc++-v3/libsupc++
-I/net/gnu-13/export/gnu/src/gcc/gcc/libstdc++-v3/include/backward
-I/net/gnu-13/export/gnu/src/gcc/gcc/libstdc++-v3/testsuite/util
-fmessage-length=0  -O2 -fgraphite-identity  -S  -o pr39447.s
(timeout = 300)
/net/gnu-13/export/gnu/src/gcc/gcc/gcc/testsuite/g++.dg/graphite/pr39447.C:1:
sorry, unimplemented: Graphite loop optimizations cannot be used^M
compiler exited with status 1
output is:
/net/gnu-13/export/gnu/src/gcc/gcc/gcc/testsuite/g++.dg/graphite/pr39447.C:1:
sorry, unimplemented: Graphite loop optimizations cannot be used^M

FAIL: g++.dg/graphite/pr39447.C (test for excess errors)

I am checking in this patch as an obvious fix.

-- 
H.J.
---
2009-03-18  H.J. Lu  <hongjiu.lu@intel.com>

	* g++.dg/dg.exp: Prune graphite.
-------------- next part --------------
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 144943)
+++ ChangeLog	(working copy)
@@ -1,3 +1,7 @@
+2009-03-18  H.J. Lu  <hongjiu.lu@intel.com>
+
+	* g++.dg/dg.exp: Prune graphite.
+
 2009-03-18  Sebastian Pop  <sebastian.pop@amd.com>
 
 	PR middle-end/39447
Index: g++.dg/dg.exp
===================================================================
--- g++.dg/dg.exp	(revision 144943)
+++ g++.dg/dg.exp	(working copy)
@@ -43,6 +43,7 @@ set tests [prune $tests $srcdir/$subdir/
 set tests [prune $tests $srcdir/$subdir/gomp/*]
 set tests [prune $tests $srcdir/$subdir/tree-prof/*]
 set tests [prune $tests $srcdir/$subdir/torture/*]
+set tests [prune $tests $srcdir/$subdir/graphite/*]
 
 # Main loop.
 dg-runtest $tests "" $DEFAULT_CXXFLAGS


More information about the Gcc-patches mailing list