[PATCH] DO_GLOBAL_CTORS_BODY needs uintptr_t

Ozkan Sezer sezeroz@gmail.com
Wed Mar 18 15:43:00 GMT 2009


On Wed, Mar 18, 2009 at 5:23 PM, Ian Lance Taylor <iant@google.com> wrote:
> Ozkan Sezer <sezeroz@gmail.com> writes:
>
>> 2009-03-17  Ozkan Sezer <sezeroz@gmail.com>
>>
>>       * gbl-ctors.h (DO_GLOBAL_CTORS_BODY): Cast to __SIZE_TYPE__ instead of
>>       unsigned long to avoid the win64 warning. (uintptr_t would be a better
>>       choice if it were reliably defined on all targets...)
>
> ChangeLog entries should just say what was changed, not why.  You can
> add the parenthetical comment to the source code if you like.  The
> ChangeLog entry should simply be "Cast to __SIZE_TYPE__ instead of
> unsigned long."
>

Would you do the change to the changelog or should I send
a new one?

> How did you test this patch?
>
> This is OK if it bootstraps on a primary platform.
>

Bootstrapped on i686-linux.

> Ian
>

Ozkan



More information about the Gcc-patches mailing list