[patch]: Fix warning in ipa-struct-reorg.c
Ian Lance Taylor
iant@google.com
Tue Mar 17 16:50:00 GMT 2009
Richard Guenther <richard.guenther@gmail.com> writes:
> On Tue, Mar 17, 2009 at 5:19 PM, Ian Lance Taylor <iant@google.com> wrote:
>> Kai Tietz <ktietz70@googlemail.com> writes:
>>
>>> 2009-03-16 Kai Tietz <kai.tietz@onevision.com>
>>>
>>> * ipa-struct-reorg.c (create_general_new_stmt): Initialize local
>>> variable rhs by NULL_TREE.
>>
>> This is OK.
>
> Well, I think the function could need some re-org and gcc_unreachable ()
> for cases it doesn't expect. Initializing rhs to NULL_TREE makes the
> mess less visible ...
As far as I can tell the function is flat out wrong right now.
Initializing rhs seems like a small positive step forward.
Ian
More information about the Gcc-patches
mailing list