[PATCH]Save/restore crtl->is_thunk for emitting thunk code (PR/debug 39378)
Ian Lance Taylor
iant@google.com
Tue Mar 17 14:32:00 GMT 2009
Jing Yu <jingyuuiuc@gmail.com> writes:
> Index: ChangeLog
> ===================================================================
> --- ChangeLog (revision 144793)
> +++ ChangeLog (working copy)
> @@ -1,3 +1,16 @@
> +2009-03-12 Jing Yu <jingyu@google.com>
> +
> + PR middle-end/39378
> + * function.h: Move is_thunk from rtl_data structure to function
> + structure.
> + * cp/method.c (use_thunk): Change is_thunk from crtl to cfun.
> + * varasm.c (assemble_start_function): Change is_thunk from crtl to
> + cfun.
> + * config/alpha/alpha.c: Change is_thunk from crtl to cfun.
> + * config/rs6000/rs6000.c: Change is_thunk from crtl to cfun.
> + * config/arm/arm.h: Change is_thunk from crtl to cfun.
> + * testsuite/g++.dg/inherit/thunk10.C: New file.
> +
Thanks for the patch. In the future, please provide the ChangeLog entry
separately in the body of the message, rather than as part of the patch
itself.
The ChangeLog entry should say what is being changed in each file. It
should look something like this:
2009-03-12 Jing Yu <jingyu@google.com>
PR middle-end/39378
* function.h (struct rtl): Move is_thunk field from here...
(struct function): ...to here.
* cp/method.c (use_thunk): Change is_thunk from crtl to cfun.
* varasm.c (assemble_start_function): Change is_thunk from crtl to
cfun.
* config/alpha/alpha.c (alpha_sa_mask): Change is_thunk from
crtl to cfun.
(alpha_does_function_need_gp, alpha_start_function): Likewise.
(alpha_output_function_end_prologue): Likewise.
(alpha_end_function, alpha_output_mi_thunk_osf): Likewise.
* config/rs6000/rs6000.c (rs6000_ra_ever_killed): Likewise.
(rs6000_output_function_epilogue): Likewise.
* config/arm/arm.h (ARM_DECLARE_FUNCTION_NAME): Likewise.
Note that thunk10.C should not be mentioned in this ChangeLog file; it
should be in testsuite/ChangeLog, as you have done separately.
> +2009-03-12 Jing Yu <jingyu@google.com>
> + PR middle-end/39378
> + * g++.dg/inherit/thunk10.C: New test.
> +
Please add a blank line between your name and the start of ChangeLog
entry.
This is OK with the adjusted ChangeLog entries.
Thanks.
Ian
More information about the Gcc-patches
mailing list