PATCH: resolve unique sections before writing the constant pool

Ian Lance Taylor iant@google.com
Fri Mar 6 05:49:00 GMT 2009


Jaka Močnik <jaka@xlab.si> writes:

> 2009-02-12  Jaka Mocnik  <jaka@xlab.si>
>
>         * gcc/varasm.c (assemble_start_function): call
>         resolve_unique_section() before outputting the
> 	constant pool. this enables the pool output code
> 	to access the actual function code section.

This is OK for gcc 4.5 (after the gcc 4.4 branch is made).

The ChangeLog entry should be properly capitalized.  It should only
describe what was changed, not why it was changed--the second sentence
should be omitted.  The lines should be a little big longer.  All in all
it should look like this:

2009-02-12  Jaka Mocnik  <jaka@xlab.si>

        * gcc/varasm.c (assemble_start_function): Call
	resolve_unique_section before outputting the constant pool.


Thanks.

Ian



More information about the Gcc-patches mailing list