[patch][plugin] Fix bug in pass insertion
Diego Novillo
dnovillo@google.com
Fri Jun 5 14:44:00 GMT 2009
On Thu, Jun 4, 2009 at 17:38, Olatunji Ruwase<tjruwase@google.com> wrote:
> The attached patch fixes a bug that could result in a plugin pass
> being inserted multiple times, even though it
> was specified to inserted only once. Also included is a testcase for this bug.
> This bug occurs when plugin pass A that is to be inserted after gcc
> pass B have the same name.
Good catch.
> 2009-06-04 Olatunji Ruwase <tjruwase@google.com>
> * plugin.c(position_pass): Skip newly inserted pass during list
> traversal to avoid repeated insertion.
>
> 2009-06-04 Olatunji Ruwase <tjruwase@google.com>
> * gcc.dg/plugin/one_time_plugin.
Blank line after date.
> c New test to detect multiple
> insertions of a plugin pass.
No need to explain what the test does in a ChangeLog entry. Just 'New
test' is fine.
> * gcc.dg/plugin/one_time-test-1.c New test case
End sentence with '.'
The rest is OK with Rafael's suggestions. Do you have write access to
the repository?
Diego.
More information about the Gcc-patches
mailing list