Add missing return false to ipcp_cloning_candidate_p

[Martin Jambor]

Hi,

On Tue, May 12, 2009 at 11:29:39AM +0200, Richard Guenther wrote:
> On Mon, May 11, 2009 at 11:03 PM, Jan Hubicka <hubicka@ucw.cz> wrote:
> >> Hi,
> >>
> >> There was a missing return false in ipcp_cloning_candidate_p(). Â Honza
> >> asked me to add it so I have committed the following patch as revision
> >> 147396 after bootstrapping and testing it on x86-64-linux.
> >
> > Thanks. Â Note that this is technically regression in 4.4 (i.e. we grow
> > code size here with no benefit), so it might be applicable also for
> > 4.4.1 if we notice it causes some improvements.
> 
> Even if not.  But give it bootstrapping/testing there.
> 

Committed as revision 149139 to the 4.4 branch after a bootstrap and
testing on x86_64-linux.

(Yeah, I know I should have done it much earlier but I completely
forgot about it and only accidentally dug this out of my email).

Martin



> Richard.
> 
> > Honza
> >>
> >> Martin
> >>
> >>
> >>
> >> 2009-05-11  Martin Jambor  <mjambor@suse.cz>
> >>
> >> Â  Â  Â  * ipa-cp.c (ipcp_cloning_candidate_p): Add missing return false.
> >>
> >>
> >> Index: gcc/ipa-cp.c
> >> ===================================================================
> >> --- gcc/ipa-cp.c      (revision 147389)
> >> +++ gcc/ipa-cp.c      (working copy)
> >> @@ -438,6 +438,7 @@ ipcp_cloning_candidate_p (struct cgraph_
> >> Â  Â  Â  Â if (dump_file)
> >> Â  Â  Â  fprintf (dump_file, "Not considering %s for cloning; no hot calls.\n",
> >> Â  Â  Â  Â  Â  Â  Â  Â cgraph_node_name (node));
> >> + Â  Â  Â return false;
> >> Â  Â  Â }
> >> Â  Â if (dump_file)
> >> Â  Â  Â fprintf (dump_file, "Considering %s for cloning.\n",
> >