Unreviewed^3 Solaris/x86 patch

Ian Lance Taylor iant@google.com
Wed Jan 28 17:58:00 GMT 2009


Rainer Orth <ro@techfak.uni-bielefeld.de> writes:

> This patch
>
> 	4.1/4.2 PATCH: Fix building libffi with Solaris 10/x86 as (PR libffi/26048)
> 	http://gcc.gnu.org/ml/gcc-patches/2008-12/msg00481.html
>
> has remained unreviewed for a long time.  Although it has been suggested to
> check it in in absence of a Solaris maintainer
>
> 	http://gcc.gnu.org/ml/gcc-patches/2008-12/msg00898.html
>
> I'm reluctant to do so since according to my understanding, it requires a
> global reviewer to approve.  Apart from this procedural issue, the patch is
> very low risk since it is very target specific and only used in a
> configuration that never worked before (i.e. GCC on 64-bit Solaris/x86 with
> Sun as).

What you really need here is a libffi maintainer.

This patch is OK.

Thanks.

Ian



More information about the Gcc-patches mailing list