[PATCH] check alias sets in add_inter_loop_mem_dep (ddg.c)

Daniel Berlin dberlin@dberlin.org
Tue Jan 20 21:43:00 GMT 2009


On Tue, Jan 20, 2009 at 3:22 PM, Ayal Zaks <ZAKS@il.ibm.com> wrote:
> Daniel Berlin <dberlin@dberlin.org> wrote:
>
>> I can't approve your patch, I don't maintain that area of the
>> compiler. I can only say that from an aliasing perspective, it is
>> correct :)
>>
>> Normally, the procedure is that you can either ask for
>> write-after-approval access, and once getting it, commit it yourself,
>> or ask someone with commit access to commit it for you.
>
> I approve the modulo-scheduler part (i.e. ddg.c). A main advantage of this
> patch is the ability to check the potential of modulo-scheduling loops by
> using __restrict'ed testcases.
>
>
>> > > > Should I also include this test in the patch?
>
> Yes, certainly. Another test using different types is also appropriate.
>
>
> Please add to the comment:
>> > > > +  if (!insn_alias_sets_conflict_p (from->insn, to->insn))
>> > > > +    /* Do not create edge if memory references have
>> > > disjoint alias sets.
>
>  Because this implies that the two memory reference will not alias even
> across iterations.
>
>> > > */
>> > > > +    return;
>
>
>> or ask someone with commit access to commit it for you.
>
> Revital, could you please commit this for Bingfeng, once the alias.{h,c}
> part is approved?.


Consider the alias.c portions approved.



More information about the Gcc-patches mailing list