[Patch/committed] [Bug target/36654] [4.2/4.3 Regression] Inlined con/de-structor breaks virtual inheritance dllimport classes

Danny Smith dansmister@gmail.com
Wed Jan 7 07:52:00 GMT 2009


I have committed this to 4.3 branch to fix the regression there.  It
does not seem to be needed on trunk.

2009-01-07  Danny Smith  <dannysmith@users.sourceforge.net>

	PR target/36654
	* config/i386/winnt-cxx.c (i386_pe_type_dllimport_p): Check
	DECL_NOT_REALLY_EXTERN rather than !DECL_EXTERNAL

Index: config/i386/winnt-cxx.c
===================================================================
--- config/i386/winnt-cxx.c	(revision 143149)
+++ config/i386/winnt-cxx.c	(working copy)
@@ -65,7 +65,7 @@
       ignore the class attribute.  */
   else if (TREE_CODE (decl) == VAR_DECL
 	   && TREE_STATIC (decl) && TREE_PUBLIC (decl)
-	   && !DECL_EXTERNAL (decl))
+	   && DECL_NOT_REALLY_EXTERN (decl))
     {
       if (!DECL_VIRTUAL_P (decl))
 	  error ("definition of static data member %q+D of "



More information about the Gcc-patches mailing list