[Patch, fortran] PR38657 - [4.3/4.4 Regression] PUBLIC/PRIVATE Common blocks

Paul Richard Thomas paul.richard.thomas@gmail.com
Mon Jan 5 19:50:00 GMT 2009


Thanks, Daniel!

On Mon, Jan 5, 2009 at 7:40 PM, Daniel Kraft <d@domob.eu> wrote:
> Paul Richard Thomas wrote:
>>
>> Yet another regression squashed.....
>>
>> This is verging on obvious.... once the problem is found:-)  The check
>> during module writing that ensured that a common block did not get
>> written twice was using the common block name rather than the symtree.
>>  This is rather akin to renamed use associated symbols, since use
>> associated common blocks have their names mangled.  The testcase is a
>> fair elaboration on the original to try to mix private and public
>> common block variables.
>>
>> Bootstrapped and regtested on x86_i64/FC9 - OK for trunk and a week
>> later for 4.3?
>
> Ok for both.  Thanks for the patch!
>
> Daniel
>
> --
> Done:  Arc-Bar-Cav-Rog-Sam-Tou-Val-Wiz
> To go: Hea-Kni-Mon-Pri-Ran
>



-- 
The knack of flying is learning how to throw yourself at the ground and miss.
       --Hitchhikers Guide to the Galaxy



More information about the Gcc-patches mailing list