[PATCH, 4.5?] Fix get_ref_base_and_extent() handling of unions and variable sized arrays

Martin Jambor mjambor@suse.cz
Mon Jan 5 12:42:00 GMT 2009


Hi,

On Sat, Jan 03, 2009 at 02:38:16PM +0100, Jan Hubicka wrote:
> > Hi,
> > 
> > On Fri, Dec 12, 2008 at 07:17:02PM +0100, Martin Jambor wrote:
> > > Hi,
> > > 
> > > this  patch  fixes bug  in  get_ref_base_and_extent()  which makes  it
> > > return wrong  max_size when dealing  with variable size  arrays within
> > > unions.
> > > 
> > > Please see discussion in the gcc mailing list, particularly the
> > > following message for details:
> > > 
> > > http://gcc.gnu.org/ml/gcc/2008-12/msg00192.html
> > > 
> > > Even though this is technically a  bug in trunk, I'm happy to postpone
> > > this until 4.5.   It may be part of the  pretty-ipa branch sooner than
> > > stage1.
> > > 
> > > Bootstrapped and tested on x86_64.
> > > 
> > 
> > I have now also bootstrapped  and tested it against pretty-ipa branch.
> > It is not ipa related per se but my current development on that branch
> > requires the fix.
> > 
> > Honza, can  I commit  it to the  branch?  (Alternatively, I  can still
> > keep it separate  in my quilt patch  set until Richi has a  look at it
> > but I do not want to intermingle it with the rest of the work).
> 
> In case I didn't OKed it already, it is OK :)
> 

Actually, it's already  commited (to the pretty-ipa branch)  for a few
days.  I will add a FIXME Richi requested shortly (I might even try to
fix it  properly myself but at  the moment it  is very low in  my todo
list).

Thanks,

Martin



More information about the Gcc-patches mailing list