PATCH, build: eliminate races

Paolo Bonzini bonzini@gnu.org
Mon Jan 5 10:38:00 GMT 2009


Ben Elliston wrote:
>>>> Clearly, there is a race between `test -d po' and `mkdir po'.  This
>>>> leads to errors from the build system about `po' not being created
>>>> because it already exists.  The following patch fixes this, using `mkdir
>>>> -p po' instead.
>> Shouldn't the "-" take care of that, though?
> 
> Sorry, I wasn't clear.  Yes, it does, but the error is still produced
> and it may confuse users.  This operation should be silent.

Makes sense.  Do we want a policy not to use - then?

Paolo



More information about the Gcc-patches mailing list