[PATCH, 4.3] Fix PR 37861 - Remove bogus "subscript is above array bounds" warning

Martin Jambor mjambor@suse.cz
Sat Feb 28 19:27:00 GMT 2009


Hi,

On Sat, Feb 28, 2009 at 11:15:36AM +0100, Richard Guenther wrote:
> On Sat, 28 Feb 2009, Martin Jambor wrote:
> 
> > Hi,
> > 
> > the fix have been on trunk for a few months now and so I have prepared
> > a fix for 4.3 against which the bug was filed so that I can close it.
> > 
> > I have bootstapped  and tested the patch without  any problems, I have
> > also verified it does fix the problem.
> > 
> > OK for the 4.3 branch?
> 
> Ok.
> 
> Thanks,
> Richard.

Committed as revision 144491.


On Sat, Feb 28, 2009 at 11:37:40AM +0100, Eric Botcazou wrote:
> > the fix have been on trunk for a few months now and so I have prepared
> > a fix for 4.3 against which the bug was filed so that I can close it.
> 
> FWIW I don't think letting a few months pass between installing a patch on 
> mainline and backporting it to a release branch is a good thing; days should 
> be sufficient.  The main risk is that the original patch had fallouts, which 
> have been fixed on the mainline but not on the branch because the patch 
> wasn't there, and they may also be backported without the subsequent fixes.
> 
> IMO the decision to backport or not a patch should be made on the day it is 
> installed on mainline, based on a benefit/risk estimate; maintainers should 
> be able to make a reasonable assessment quickly.  Then one can wait a few 
> days for the sake of safety, but not weeks nor months.

This  long delay  was not  intentional, it  happened only  because the
backport had a low  priority on my to do list.  I  will strive to make
the it shorter  next time (the delay, there is  no point in attempting
to shorten the list).

Thanks,

Martin



More information about the Gcc-patches mailing list