ping: backport to 4.3 the fix for middle-end/36578

[Richard Guenther]

On Wed, Feb 25, 2009 at 9:44 PM, Janis Johnson <janis187@us.ibm.com> wrote:
> On Wed, 2009-02-25 at 21:04 +0100, Richard Guenther wrote:
>> On Wed, Feb 25, 2009 at 7:27 PM, Janis Johnson <janis187@us.ibm.com> wrote:
>> > Ping:
>> >
>> >  http://gcc.gnu.org/ml/gcc-patches/2009-02/msg00434.html
>> >
>> > This patch backports to the 4.3 branch a mainline fix for a regression
>> > introduced in 3.4.  The backport is not complete as it omits additional
>> > checks for rounding that are not available in the 4.3 branch, but it is
>> > an improvement and fixes middle-end/36578 and c/39034, a wrong-code bug
>> > for decimal float.
>> >
>> > Here's the ChangeLog entry for the fix; there are also new tests:
>> >
>> >        Backport from mainline:
>> >        2008-10-29  Joseph Myers  <joseph@codesourcery.com>
>> >
>> >        PR middle-end/36578
>> >        * convert.c (convert_to_real): Do not optimize conversions of
>> >        binary arithmetic operations between binary and decimal
>> >        floating-point types.  Consider mode of target type in determining
>> >        decimal type for arithmetic.  Unless
>> >        flag_unsafe_math_optimizations, do not optimize binary conversions
>> >        where this may change rounding behavior.
>> >        * real.c (real_can_shorten_arithmetic): New.
>> >        * real.h (real_can_shorten_arithmetic): Declare.
>> >
>> > I've copied Joseph, who wrote the original patch, and Richard Guenther,
>> > who approved it.
>>
>> Backports for regressions are generally ok, backports for wrong-code bugs
>> as well if they are important and the patch is not too intrusive.
>>
>> Bootstrap/regtest on the branch is of course required.
>
> This was bootstrapped (all languages but Ada) and regression tested
> on the branch for powerpc64-linux, tested with -m32/-m64.  OK?

Yes.

> As I said, the backport is not complete but it fixes the reported
> problems.

Thanks,
Richard.

> Janis
>
>