PATCH: Turn on -Wpsabi only for the C languages

H.J. Lu hjl.tools@gmail.com
Wed Feb 18 17:43:00 GMT 2009


On Wed, Feb 18, 2009 at 9:16 AM, Manuel López-Ibáñez
<lopezibanez@gmail.com> wrote:
> 2009/2/18 Jakub Jelinek <jakub@redhat.com>:
>> On Wed, Feb 18, 2009 at 07:08:51AM -0800, H.J. Lu wrote:
>>> We want to turn on -Wpsabi for the C languages. This patch does it.
>>> OK for trunk?
>>
>> This looks wrong for me.  Either Fortran, Java, Ada etc. don't pass
>> union arguments containing long double, then obviously the warning will
>> never be emitted for them, or they do and in that case there is an ABI
>> change that the people would be better informed about.
>
> This Wpsabi is totally weird. If it is a warning, then why not use
> warning (OPT_Wpsabi) ? This way people could tell how to disable it.
> On the other hand, if it is not a warning but a note, why just not
> emit it without needing any -W* option? What is -Werror=psabi meaning
> in that case?
>

-Wpsabi is undocumented on purpose. We want -Wabi to warn all
ABI changes, include psABI changes.  But -Wabi is off by default.
But we want psABI warning on by default. The only way to control
it is via -Wabi.

-- 
H.J.



More information about the Gcc-patches mailing list