PATCH: PR target/39082: union with long double doesn't follow x86-64 psABI

Richard Guenther richard.guenther@gmail.com
Wed Feb 4 15:13:00 GMT 2009


On Wed, Feb 4, 2009 at 3:47 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Wed, Feb 04, 2009 at 06:45:13AM -0800, H.J. Lu wrote:
>> On Tue, Feb 03, 2009 at 06:31:21PM -0800, H.J. Lu wrote:
>> > Hi,
>> >
>> > This patch fixes the psABI violation by passing an aggregate in
>> > memory if X87UP class isn't preceded by X87 class. I also added some
>> > abi testcases based on
>> >
>> > https://www.x86-64.org/svn/trunk/abitest
>> >
>> > OK for trunk if it passes tests on Linux/x86-64?
>> >
>>
>> It passed all tests.  OK for trunk and active branches?
>
> I'm not convinced such an ABI change can be made on release branches.

I am not convinced such ABI changes should be done without adding
a diagnostic for the cases that changed.  And I agree that release branches
should not be touched.

Richard.



More information about the Gcc-patches mailing list