[patch] use of atomic builtins for arm-linux-eabi in boehm-gc

Matthias Klose doko@ubuntu.com
Mon Dec 14 00:26:00 GMT 2009


On 09.12.2009 11:16, Richard Earnshaw wrote:
>> Current trunk fails to build on arm-linux-gnueabi in boehm-gc, when
>> configured
>> --with-mode=thumb:
>>
>> /tmp/ccVpqOWm.s: Assembler messages:
>> /tmp/ccVpqOWm.s:1160: Error: selected processor does not support `swp
>> r3,r3,[r2]'
>> /tmp/ccVpqOWm.s:2472: Error: selected processor does not support `swp
>> r3,r3,[r2]'
>> /tmp/ccVpqOWm.s:3232: Error: selected processor does not support `swp
>> r3,r3,[r2]'
>> make[5]: *** [alloc.lo] Error 1
>>
>> arm-linux-gnueabi now provides the atomic builtins; use them
>> unconditionally (as
>> libjava does).
>>
>> Ok for the trunk, if testing succeeds? The build on trunk configured
>> with
>> --with-mode=thumb fails for other reasons (PR42093), currently testing
>> the patch
>> for the 4.4 branch.
> 2009-12-09  Matthias Klose<doko@ubuntu.com>
>
> 	* include/private/gc_locks.h: For __ARM_EABI__ define
> 	GC_test_and_set  GC_clear to use the atomic builtins.
>
> OK for trunk once testing is complete.

a test build did suceed without regressions. now that the _sync_synchronise fix 
is backported to the 4.4 branch, ok to commit to 4.4 branch as well?

> Please also notify the upstream maintainer of boehm-gc, or this patch may
> get lost in a future merge.

forwarded to Hans Boehm.

   Matthias



More information about the Gcc-patches mailing list