[PATCH] GCC symdb

Dave Korn dave.korn.cygwin@googlemail.com
Wed Dec 2 06:45:00 GMT 2009


Daniel Jacobowitz wrote:
> On Wed, Dec 02, 2009 at 10:14:57AM +0800, Yunfeng ZHANG wrote:
>> So how about my patch?
> 
> What Joseph said.
> 
> You're trying to work with an existing community of developers.  If
> you don't demonstrate that you're willing to work with them on their
> terms, no one is going to take the time to work with you either.
> 
> You haven't even put a description of what the patch is for 

  I took a quick look.

  It's a bit of an ugly hack that links gcc into an sqlite client lib and gets
it to dump symbol info in a database.  Crude and unautoconfed, it will fail
everywhere sqlite isn't installed.  The entire db schema and query strings are
hardcoded, (and it even hardcodes the specific path to zyf's home directory on
his own personal pc into gcc/toplev.c, I don't know how that's supposed to
work on any other computer in the world!).  Mixed in with this is what ought
to be a separate patch that does something, I'm not clear what, about tracking
preprocessor macro expansions by adding extra cpp callbacks.

  This (the dump syntax info to a database bit) might make a decent concept
for a plugin, but it probably doesn't belong in the compiler proper, and it's
not cleanly implemented here even if it did belong.

    cheers,
      DaveK



More information about the Gcc-patches mailing list