[PATCH, c++ diagnostics] Fix c++ front end i18n problems
Paolo Bonzini
bonzini@gnu.org
Tue Dec 1 09:43:00 GMT 2009
On 12/01/2009 10:37 AM, Gabriel Dos Reis wrote:
>> > I suggest you leave "candidate is" aside in the beginning and submit a patch
>> > for the rest. Then you can do a separate patch to fix the other issue --
>> > otherwise you'll make the same mistake as me and the patches will lie
>> > uncommitted for seven more years.;-)
> I don't understand this comment.
I'm suggesting to split the patch in two, to avoid making it too
complicated which was my fault when I wrote the %s-elimination patch
that Shujing took inspiration from. That was 2002.
Taking candidates is/candidates into a separate patch was a natural place.
Regarding enums, my impression was that the coding standard was "no
typedef", but it is mixed:
~/devel/gcc/gcc pbonzini$ grep typedef.*enum * | wc -l
54
~/devel/gcc/gcc pbonzini$ grep ^enum * | wc -l
382
so that objection is withdrawn.
Paolo
More information about the Gcc-patches
mailing list