[patch] Allow build to specify what sed mkheaders uses

Steve Ellcey sje@cup.hp.com
Fri Aug 28 18:54:00 GMT 2009


On Fri, 2009-08-28 at 09:45 +0200, Paolo Bonzini wrote:

> Yes, that would be a very small patch in Makefile.tpl, plus adding 
> AC_PROG_SED to the toplevel configure.ac.
> 
> Can you test this?
> 
> Paolo

This patch did not work but after some troubleshooting I found I could
add 'SED = @SED@' to Makefile.tpl along with your changes, regenerate
Makefile.in, and then it did work.

That said, I would like to express a slight preference for my original
patch.  With this patch and using 'SED=/usr/bin/sed' on the configure
line it is somewhat difficult to understand where $SED is used and where
sed (as found with $PATH) is used.  libtool uses $SED but most (all?) of
the configure scripts and Makefiles just use 'sed'.  Maybe it is that
simple but my change affected one use, and only one use,
and I liked that better then this more global change.  But either one
will work for me in fixing the problem I am trying to address.

Steve Ellcey
sje@cup.hp.com



More information about the Gcc-patches mailing list