[PATCH] Dwarf2 "main" pointer die for VMS
Douglas B Rupp
rupp@gnat.com
Sun Aug 16 08:22:00 GMT 2009
I made your recommend changes and was doing some final testing when I
realized the patch depends on some new prologue/epilogue debug labels
introduced in this as yet unreviewed patch:
http://gcc.gnu.org/ml/gcc-patches/2009-07/msg01339.html
I see you're a designated debug reviewer, so perhaps you could take a
look at it if convenient.
Jim Wilson wrote:
> On 07/23/2009 01:21 PM, Douglas B Rupp wrote:
>> The VMS debugger needs this.
>
> You are adding a variable and function prototype in a section of code
> for debug hooks, and these aren't debug hooks. It seems more
> appropriate to put them about 400 lines later where the bulk of the
> dwarf2 function prototypes are.
>
> A blank line between the variable definition and the function prototype
> would be good, and a comment for the variable would be nice.
>
> I see that you are setting the variable, but you are never clearing it
> or freeing the string anywhere. I think the variable should be
> initialized to zero in dwarf2out_init just to be safe. Most everything
> else in the file is initialized here.
>
> Otherwise this looks OK to me.
>
> If you already have other VMS_DEBUGGING_INFO stuff approved, then it
> would be nice if the VMS stuff can be grouped together to reduce the
> number of ifdefs.
>
> Jim
>
More information about the Gcc-patches
mailing list