[PATCH] fix wrong code for push of long double

Mikulas Patocka mikulas@artax.karlin.mff.cuni.cz
Sun Aug 9 23:30:00 GMT 2009


On Thu, 6 Aug 2009, Uros Bizjak wrote:

> On 08/06/2009 05:09 AM, Mikulas Patocka wrote:
> 
> > My tests are valid on all architectures, they contain portable code (is
> > there any arch without long double?). On other architectures they don't
> > test any known bug, but they could be run anyway to protect the bug from
> > reappearing. I don't see why you want to run them only on i386.
> >    
> 
> x86_64 simply does not use these code paths, since you can't use pushq
> together with pushl to move 3x 32bit decomposed XFmode operand.

The main purpose of the test suite is to make sure that the bugs won't 
reappear. And they may reappear on any architecture in the future, even if 
it is driver by completely different code. So I think, if the testcase is 
portable, it should be run on all architectures.

The only exception would be an architecture without long double. Is there 
such?

Mikulas



More information about the Gcc-patches mailing list