[PATCH] fix wrong code for push of long double

Kaveh R. Ghazi ghazi@caip.rutgers.edu
Fri Aug 7 16:55:00 GMT 2009


From: "Uros Bizjak" <ubizjak@gmail.com>

> I have removed wrong test, __float128 is not supported for i686 for 4.3.

Thanks.

>> Unrelated to this patch, I also see errors on 4.3 and 4.4 on ssp-1.c when
>> using -m32 and -fpic/-fPIC.  You may wish to take a look as well:
>>
>> FAIL: gcc.dg/ssp-1.c execution test
>>
>> *** stack smashing detected ***: ./ssp-1.exe terminated
>>
>> This one started around 7/23/2009 and may have been caused by one of your
>> x86 checkins e.g. for PR40832.
>>
>
> No, I don't think any of these patches caused this failure. 40832 only 
> substitutes a .word with is equivalent define, and is not triggered in 
> ssp-1.exe. The other one of my patches deals with vectorisation and is 
> also not triggered for this case.

Agreed, upon further investigation I cannot get rid of the fail by reverting 
the recent patches on 4.3.  So it wasn't something you did.  I think around 
the same timeframe the linux distro was updated by the sysadmin of the 
machine in question.  So perhaps a different binutils or something related 
may have triggered it.

I also notice that the testcase differs on mainline vs 4.3/4.4, and the 
trunk doesn't have the error.  So that is another avenue of discovery I will 
pursue.

Thanks,
--Kaveh



More information about the Gcc-patches mailing list