[PATCH] gimplify-unit-at-a-time (final)

Richard Guenther rguenther@suse.de
Mon Aug 3 10:26:00 GMT 2009


On Sat, 1 Aug 2009, Paolo Bonzini wrote:

> On 07/07/2009 05:30 PM, Richard Guenther wrote:
> > +     "diagnose_omp_blocks",		/* name */
> 
> I think this should be "*diagnose_omp_blocks".
> 
> > +     "warn_unused_result",		/* name */
> 
> Same.
> 
> > +   /* This must also call cgraph_finalize_compilation_unit and
> > +      cgraph_optimize.  */
> 
> I don't think so, since cgraph_optimize is static. :-)  (It should call
> c_f_c_u only).

Indeed.  Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to
trunk.

Richard.

2009-08-03  Richard Guenther  <rguenther@suse.de>

	* tree-cfg.c (pass_warn_unused_result): Mark name that no dump
	file will be created.
	* omp-low.c (pass_diagnose_omp_blocks): Likewise.
	* toplev.c (compile_file): Adjust comment.

Index: gcc/tree-cfg.c
===================================================================
*** gcc/tree-cfg.c	(revision 150366)
--- gcc/tree-cfg.c	(working copy)
*************** struct gimple_opt_pass pass_warn_unused_
*** 7456,7462 ****
  {
    {
      GIMPLE_PASS,
!     "warn_unused_result",		/* name */
      gate_warn_unused_result,		/* gate */
      run_warn_unused_result,		/* execute */
      NULL,				/* sub */
--- 7456,7462 ----
  {
    {
      GIMPLE_PASS,
!     "*warn_unused_result",		/* name */
      gate_warn_unused_result,		/* gate */
      run_warn_unused_result,		/* execute */
      NULL,				/* sub */
Index: gcc/omp-low.c
===================================================================
*** gcc/omp-low.c	(revision 150366)
--- gcc/omp-low.c	(working copy)
*************** struct gimple_opt_pass pass_diagnose_omp
*** 6931,6937 ****
  {
    {
      GIMPLE_PASS,
!     "diagnose_omp_blocks",		/* name */
      gate_diagnose_omp_blocks,		/* gate */
      diagnose_omp_structured_block_errors,	/* execute */
      NULL,				/* sub */
--- 6931,6937 ----
  {
    {
      GIMPLE_PASS,
!     "*diagnose_omp_blocks",		/* name */
      gate_diagnose_omp_blocks,		/* gate */
      diagnose_omp_structured_block_errors,	/* execute */
      NULL,				/* sub */
Index: gcc/toplev.c
===================================================================
*** gcc/toplev.c	(revision 150366)
--- gcc/toplev.c	(working copy)
*************** compile_file (void)
*** 1034,1041 ****
  
    ggc_protect_identifiers = false;
  
!   /* This must also call cgraph_finalize_compilation_unit and
!      cgraph_optimize.  */
    lang_hooks.decls.final_write_globals ();
  
    if (errorcount || sorrycount)
--- 1034,1040 ----
  
    ggc_protect_identifiers = false;
  
!   /* This must also call cgraph_finalize_compilation_unit.  */
    lang_hooks.decls.final_write_globals ();
  
    if (errorcount || sorrycount)



More information about the Gcc-patches mailing list