[PATCH] Fix bootstrap fail on spu vs. ira.c/genpreds

Dave Korn dave.korn.cygwin@googlemail.com
Mon Apr 27 16:28:00 GMT 2009


Vladimir Makarov wrote:
>> gcc/ChangeLog
>>
>>     * ira.c (setup_cover_and_important_classes):  Use safe macro
>>     REG_CLASS_FOR_CONSTRAINT instead of calling regclass_for_constraint
>>     directly.
>>     * genpreds.c (write_tm_preds_h):  Output suitable definition of
>>     REG_CLASS_FOR_CONSTRAINT.

> The patch posted in
> 
> http://gcc.gnu.org/ml/gcc/2009-04/msg00698.html
> 
> is done for older version of ira.c.

  Oops, yes; I updated it before I started the build, here's the current version.

> Other than that the patch is ok.  Although, personally, I'd prefer the 
> following patch (because it does not create a new macro which is used only
> in one place of the compiler):

  Your solution is clean, but if anyone ever wants to call
regclass_for_constraint again in the future we might run into the same problem
again, might we not?  I don't really mind which patch goes in, it's your call.

    cheers,
      DaveK


-------------- next part --------------
A non-text attachment was scrubbed...
Name: r146825-patch.diff
Type: text/x-c
Size: 1443 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20090427/9fd48016/attachment.bin>


More information about the Gcc-patches mailing list