[trunk][patch] Install headers and plugin-version.o

Diego Novillo dnovillo@google.com
Tue Apr 21 15:52:00 GMT 2009


I didn't actually comment on the patch itself, sorry.  The one
thing I see is that we are always installing these headers, if
plugins are disabled we shouldn't.

You should get a proper review from a configury maintainer,
however.  I don't feel confident enough in this area to give it a
thorough review.

> diff --git a/gcc/Makefile.in b/gcc/Makefile.in
> index f4f6764..4446340 100644
> --- a/gcc/Makefile.in
> +++ b/gcc/Makefile.in
> @@ -481,6 +481,10 @@ libexecdir = @libexecdir@
>  libsubdir = $(libdir)/gcc/$(target_noncanonical)/$(version)
>  # Directory in which the compiler finds executables
>  libexecsubdir = $(libexecdir)/gcc/$(target_noncanonical)/$(version)
> +# Directory in which plugin objects are installed
> +plugindir = $(libexecsubdir)/plugin
> +# Directory in which plugin headers are installed
> +plugin_includedir = $(plugindir)/include

This may look a bit odd, but makes sense to me.  It takes advantage of the
versioning feature in libexec.  The plugin headers should be
associated with a specific gcc version.


Diego.



More information about the Gcc-patches mailing list