[committed][lto merge]: Various minor fixes

Diego Novillo dnovillo@google.com
Fri Apr 17 21:59:00 GMT 2009


On Fri, Apr 17, 2009 at 17:55, Richard Guenther
<richard.guenther@gmail.com> wrote:

>> +void
>> +find_referenced_vars_in (gimple stmt)
>
> Why export this function?  Are there outside uses on the branch?

Yes.  I forgot to mention that, sorry.  I'll commit the code to use it
when I start moving in LTO-specific changes.


>> @@ -3003,6 +3003,7 @@ create_expression_by_pieces (basic_block
>>              add_to_value (VN_INFO (forcedname)->value_id, nameexpr);
>>              if (!in_fre)
>>                bitmap_value_replace_in_set (NEW_SETS (block), nameexpr);
>> +             gcc_assert (AVAIL_OUT (block));
>
> Uh.  That is odd.  We certainly do not test this in other places and AVAIL_OUT
> is allocated for all blocks.
>
> Thus, can you instead revert it on the branch (and now trunk)?

*shrug*   It was useful when LTO was miscompiling types causing
confusion here.  I can remove the assertion if it irritates you.


Diego.



More information about the Gcc-patches mailing list