[PATCH][SH] Multilib selection rework

[Andrew Stubbs]

On 09/04/09 18:26, Ralf Wildenhues wrote:
>> +		!*)	# TM_MULTILIB_EXCEPTIONS_CONFIG is used by t-sh
>
> Quoting within shell 'case' patterns should be done with a backslash.

I've fixed this one.

>> +			# It is passed the MULTILIB_EXCEPTIONS verbatim.
>> +			TM_MULTILIB_EXCEPTIONS_CONFIG="${TM_MULTILIB_EXCEPTIONS_CONFIG} `echo $sh_multilib | sed 's/^!//'`" ;;

This one is already quoted?

>> --- src/gcc-mainline/gcc/config/sh/t-sh.orig
>> +++ src/gcc-mainline/gcc/config/sh/t-sh
>
>> +MULTILIB_OSDIRNAMES = \
>> +	$(OTHER_ENDIAN)=!$(OTHER_ENDIAN) \
>
> Here I guess you can just use single or double quotes.

This is not in a shell script, it's in a makefile. The make variable 
must be quoted before it's passed to any shell, or the spaces wouldn't 
work, so I think this is safe.

Is the attached patch OK? I really want to get this, or something like 
it, checked in.

Thanks

Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gcc-multilibs.patch
Type: text/x-diff
Size: 20389 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20090417/a6a97c5e/attachment.bin>