[Patch, Fortran] PING: PR fortran/37746: -fbounds-check for string lengths of dummy arguments

[Daniel Kraft]

Hi Steve,

after some time, rediffed and addressed your comments below.  Running a 
fresh regtest now.

Ok for trunk if successful?

Daniel

Steve Kargl wrote:
> On Sat, Mar 28, 2009 at 10:57:50PM +0100, Daniel Kraft wrote:
>> Hi,
>>
>> PING for the patch below.
>>
>> No regressions with a fresh test.  Ok for trunk?
>>
> 
> A couple of comments.
> 
> First, your testcases contain MODULEs.  Do you need to cleanup
> any *.mod files.  That is, add
> 
> !{ dg-final { cleanup-modules "module names here" } }
> 
> where needed.
> 
>> +static void
>> +add_argument_checking (stmtblock_t* block, gfc_symbol* sym)
> 
> Elsewhere in gfortran one finds for whitespace about * either
> 
>    add_argument_checking (stmtblock_t * block, gfc_symbol * sym)
> 
> or
> 
>    add_argument_checking (stmtblock_t *block, gfc_symbol *sym)
> 
>> +{
>> +  gfc_formal_arglist* formal;
> 
> The preferred style is 'gfc_formal_arglist *formal'.
> 
>> +	gfc_symbol* fsym;
>> +	gfc_charlen* cl;
>> +	const char* message;
> 
> Ditto.

-- 
Done:  Arc-Bar-Cav-Ran-Rog-Sam-Tou-Val-Wiz
To go: Hea-Kni-Mon-Pri
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch2.changelog
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20090411/c731ae2e/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch2.diff
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20090411/c731ae2e/attachment-0001.ksh>