tests for --help

[Rafael Espindola]

> Usually a .exp file is infrastructure for tests from other files, so
> help.exp deserves a comment at the start that it is a set of tests.
Done.

> Some of the comments are not full sentences, some don't start with a
> capitalized word, and some don't end with a period.  Some are missing
> (meaning it would be helpful to have additional comments as well).

I fixed the capitalized words and missing periods. Ralf, can you take
a look at the missing comments?

> In help.exp, it would be easier to read the calls to check_for_options
> if the arguments were passed as strings instead of within braces; I'm
> pretty sure that would work.

It does except for strings with newlines or +. I changed all other strings.

> It shouldn't be necessary to use "\{" for puts; in other files "{"
> comes through just fine.

Done.

> In proc check_for_options it's confusing to have an argument called
> xfail when the proc calls a procedure of that name; please rename the
> argument to lessen the chances for confusion.

Done.

> Why is there an unconditional "pass $test" at the end of options.exp?

No idea. Ralf?

> Janis
>
>

Thanks,
-- 
Rafael Avila de Espindola

Google | Gordon House | Barrow Street | Dublin 4 | Ireland
Registered in Dublin, Ireland | Registration Number: 368047
-------------- next part --------------
A non-text attachment was scrubbed...
Name: help.patch
Type: text/x-patch
Size: 5958 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20090409/c9d915e5/attachment.bin>